[MOAB-dev] ReadCGM test additions / re-factor

Tim Tautges (ANL) tautges at mcs.anl.gov
Wed Jan 8 13:12:42 CST 2014


I think forking then doing pull requests would work best.  Whether you do your own branches from there is up to you, the 
PRs will still be against the master though.

- tim

On 01/07/2014 03:39 PM, Patrick Shriwise wrote:
> Hi all,
>
> I'm one of Paul Wilson's student's if I haven't mentioned that already. As part of my research I will be writing more
> extensive tests for ReadCGM within MOAB and performing a re-factor of ReadCGM.cpp itself to make the code more modular
> in preparation for its move into Meshkit.
>
>
> As I'm doing this there are several ways of accomplishing the addition of code. One is by keeping all new tests in a
> single branch (the one I have just made a pull request for) where they will accumulate and be pushed each time a new one
> is completed. The other is by creating a new branch for each new test and creating a new pull request each time a new
> test is completed. Using either method for test additions, the re-factor will exist in its own branch that will be
> rebased on the testing branches. The re-factor will then be added upon completion.
>
> Both methods of adding tests are fine with me, but I wanted to see which is most agreeable to the fathom team. I'm happy
> to go with whichever seems best or more convenient for the group.
>
> Cheers,
>

-- 
================================================================
"You will keep in perfect peace him whose mind is
   steadfast, because he trusts in you."               Isaiah 26:3

              Tim Tautges            Argonne National Laboratory
          (tautges at mcs.anl.gov)      (telecommuting from UW-Madison)
  phone (gvoice): (608) 354-1459      1500 Engineering Dr.
             fax: (608) 263-4499      Madison, WI 53706



More information about the moab-dev mailing list