[MOAB-dev] commit/MOAB: janehu: Fixed the bug Andy Davis reported for getting graphics for edges, the first tol is angle tolerance, in degree.

[Jiangtao Hu]

Just talked and checked with Andy about cgm12.2, it seems that get_graphics for curves in cubit12.2 and below does use a distance tolerance, and cubit13.1 and above added an angle tolerance. 

I just changed ReadCGM.cpp according to the finding. 
 
Jane 


Asst. Researcher
Dept. of Engineering Physics
UW @ Madison


"And we know that for those who love God, that is, for those who are called according to his purpose, all things are working together for good." (Romans 8:28)



On Tuesday, December 3, 2013 11:24 AM, Paul Wilson <wilsonp at engr.wisc.edu> wrote:
 
Hi Jane

Did this interface change? In CGM? In ACIS?

Since faceting tolerance is the primary parameter we use, it probably needs to be still passed into the get_graphics method, perhaps as well as a default norm_tol.

Paul

-- --
Professor, Nuclear Engineering
Faculty Director, Advanced Computing Infrastructure
UW-Madison
wilsonp at engr.wisc.edu, 608.263.0807
Sent from my iPhone


On Dec 3, 2013, at 11:17, commits-noreply at bitbucket.org wrote:

> 1 new commit in MOAB:
> 
> https://bitbucket.org/fathomteam/moab/commits/119198dc4d96/
> Changeset:   119198dc4d96
> Branch:      master
> User:        janehu
> Date:        2013-12-03 18:15:13
> Summary:     Fixed the bug Andy Davis reported for getting graphics for edges, the first tol is angle tolerance, in degree.
> 
> Affected #:  1 file
> 
> diff --git a/src/io/ReadCGM.cpp b/src/io/ReadCGM.cpp
> index 13b64fb..9b6ba09 100644
> --- a/src/io/ReadCGM.cpp
> +++ b/src/io/ReadCGM.cpp
> @@ -474,7 +474,7 @@ ErrorCode ReadCGM::load_file(const char *cgm_file_name,
>     RefEdge* edge = dynamic_cast<RefEdge*>(ci->first);
>     Curve* curve = edge->get_curve_ptr();
>     data.clean_out();
> -    edge->get_graphics( data, faceting_tol);
> +    edge->get_graphics( data, norm_tol);
>     if (CUBIT_SUCCESS != s)
>       return MB_FAILURE;
> 
> Repository URL: https://bitbucket.org/fathomteam/moab/
> 
> --
> 
> This is a commit notification from bitbucket.org. You are receiving
> this because you have the service enabled, addressing the recipient of
> this email.
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/moab-dev/attachments/20131203/4f3805c5/attachment.html>