[MOAB-dev] Why I owe Iulian a beer (was: r5489 - in MOAB/trunk: doc src/io tools/mbcoupler)

Tim Tautges tautges at mcs.anl.gov
Sun Apr 22 21:15:05 CDT 2012


That's what I get for making quick changes.  I'd removed a dependency on ReadParallel from mbcoupler_test, since 
currently ReadParallel isn't part of the officially-installed API.  Trouble is, specifying read through ReadParallel was 
how we were associating each of the source/target meshes with the proper ParallelComm.  Taking out ReadParallel resulted 
in both meshes being associated with the base instance, leaving nothing in the sets to couple.  Or something like that. 
  Iulian had pointed out that mbcoupler_test wasn't really doing anything about 4 days ago, but I figured it was him not 
running the problem correctly.  That'll teach me.

Iulian, mbcoupler_test now works as advertised; run with:

mpiexec -np 2 ./mbparallelcomm_test

and it should produce output that looks like:


tautges at tautges-e4300:~/code/MOABpar/tools/mbcoupler$ mpiexec -np 2 ./mbcoupler_test
Mesh files not entered; using default files ../../../MOABclean/MeshFiles/unittest/64bricks_1khex.h5m and 
../../../MOABclean/MeshFiles/unittest/64bricks_12ktet.h5m
Interpolation field name not given, using default of vertex_field
No arguments given; using output file dum.h5m.
Mesh files not entered; using default files ../../../MOABclean/MeshFiles/unittest/64bricks_1khex.h5m and 
../../../MOABclean/MeshFiles/unittest/64bricks_12ktet.h5m
Interpolation field name not given, using default of vertex_field
No arguments given; using output file dum.h5m.
Parallel Read times:
   0.109114 PARALLEL READ PART
   0.0858841 PARALLEL RESOLVE_SHARED_ENTS
   0.0298569 PARALLEL EXCHANGE_GHOSTS
   0.00246406 PARALLEL RESOLVE_SHARED_SETS
   0.225054 PARALLEL TOTAL
Proc 0 iface entities:
Proc     446 0d iface entities.
     1080 1d iface entities.
     636 2d iface entities.
     0 3d iface entities.
     (446 verts adj to other iface ents)
Parallel Read times:
   0.190977 PARALLEL READ PART
   0.145103 PARALLEL RESOLVE_SHARED_ENTS
   0.131522 PARALLEL EXCHANGE_GHOSTS
   0.00399399 PARALLEL RESOLVE_SHARED_SETS
   0.469953 PARALLEL TOTAL
1 iface entities:
     446 0d iface entities.
     1080 1d iface entities.
     636 2d iface entities.
     0 3d iface entities.
     (446 verts adj to other iface ents)
Proc 1: box min/max, tree depth = (-0.5,-0.5,-0.5), (3.5,1.5,3.5), 12
Proc 0: box min/max, tree depth = (-0.5,1.5,-0.5), (3.5,3.5,3.5), 12
point location: wanted 1096 got 1019 locally, 77 remote, missing 0
point location: wanted 1376 got 1193 locally, 183 remote, missing 0

Max time : 2.26571 0.067872 0.00307703 (inst loc interp -- 2 procs )
Wrote dum.h5m
mbcoupler_test complete.
WriteHDF5:           0.175747
   gather mesh:       0.046762
   create file:       0.108039
     create nodes:    0.02457
     negotiate types: 7.39098e-05
     craete elem:     0.00078702
     file id exch:    0.0388541
     create adj:      0.0100751
     create set:      0.00707388
       shared ids:    2.40803e-05
       shared data:   5.19753e-05
       set offsets:   0.00692511
     create tags:     0.032994
   coordinates:       0.000541925
   connectivity:      0.017906
   sets:              0.00828004
     set descrip:     0.000555992
     set content:     0.006037
     set parent:      0.000854969
     set child:       0.000818014
   adjacencies:       1.97887e-05
   tags:              0.017417
     dense data:      0.00207114
     sparse data:     0.015233
     var-len data:    0
Wrote dum.h5m
mbcoupler_test complete.

- tim

-------- Original Message --------
Subject: [MOAB-dev] r5489 - in MOAB/trunk: doc src/io tools/mbcoupler
Date: Sun, 22 Apr 2012 21:09:47 -0500 (CDT)
From: tautges at mcs.anl.gov
Reply-To: moab-dev at mcs.anl.gov
To: moab-dev at mcs.anl.gov

Author: tautges
Date: 2012-04-22 21:09:46 -0500 (Sun, 22 Apr 2012)
New Revision: 5489

Modified:
    MOAB/trunk/doc/metadata_info.doc
    MOAB/trunk/src/io/ReadNCDF.cpp
    MOAB/trunk/src/io/Tqdcfr.cpp
    MOAB/trunk/tools/mbcoupler/mbcoupler_test.cpp
Log:
Fixing bug I'd introduced the last time I touched mbcoupler_test.  Iulian,
I owe you a beer.

Changed the name of the tag used to indicate reverse-sense faces in neumann
sets, from SENSE to NEUSET_SENSE; updated metadata_info document accordingly.



Modified: MOAB/trunk/doc/metadata_info.doc
===================================================================
(Binary files differ)

Modified: MOAB/trunk/src/io/ReadNCDF.cpp
===================================================================
--- MOAB/trunk/src/io/ReadNCDF.cpp	2012-04-22 13:31:40 UTC (rev 5488)
+++ MOAB/trunk/src/io/ReadNCDF.cpp	2012-04-23 02:09:46 UTC (rev 5489)
@@ -1052,7 +1052,7 @@
              // set the reverse tag
            Tag sense_tag;
            int dum_sense = 0;
-          result = mdbImpl->tag_get_handle("SENSE", 1, MB_TYPE_INTEGER, sense_tag,
+          result = mdbImpl->tag_get_handle("NEUSET_SENSE", 1, MB_TYPE_INTEGER, sense_tag,
                                             MB_TAG_SPARSE|MB_TAG_CREAT, &dum_sense);
            if (result != MB_SUCCESS) return result;
            dum_sense = -1;

Modified: MOAB/trunk/src/io/Tqdcfr.cpp
===================================================================
--- MOAB/trunk/src/io/Tqdcfr.cpp	2012-04-22 13:31:40 UTC (rev 5488)
+++ MOAB/trunk/src/io/Tqdcfr.cpp	2012-04-23 02:09:46 UTC (rev 5489)
@@ -742,7 +742,7 @@
      if (tmp_result != MB_SUCCESS) result = tmp_result;
      int def_val = 1;
      Tag sense_tag;
-    tmp_result = mdbImpl->tag_get_handle("SENSE", 1, MB_TYPE_INTEGER, sense_tag,
+    tmp_result = mdbImpl->tag_get_handle("NEUSET_SENSE", 1, MB_TYPE_INTEGER, sense_tag,
                                       MB_TAG_SPARSE|MB_TAG_CREAT, &def_val);
      if (tmp_result != MB_SUCCESS) result = tmp_result;
      def_val = -1;
@@ -800,7 +800,7 @@
      if (tmp_result != MB_SUCCESS) result = tmp_result;
      int def_val = 1;
      Tag sense_tag;
-    tmp_result = mdbImpl->tag_get_handle("SENSE", 1, MB_TYPE_INTEGER, sense_tag,
+    tmp_result = mdbImpl->tag_get_handle("NEUSET_SENSE", 1, MB_TYPE_INTEGER, sense_tag,
                                        MB_TAG_SPARSE|MB_TAG_CREAT, &def_val);
      if (tmp_result != MB_SUCCESS && tmp_result != MB_ALREADY_ALLOCATED) result = tmp_result;
      def_val = -1;

Modified: MOAB/trunk/tools/mbcoupler/mbcoupler_test.cpp
===================================================================
--- MOAB/trunk/tools/mbcoupler/mbcoupler_test.cpp	2012-04-22 13:31:40 UTC (rev 5488)
+++ MOAB/trunk/tools/mbcoupler/mbcoupler_test.cpp	2012-04-23 02:09:46 UTC (rev 5489)
@@ -1,6 +1,8 @@
  #include "moab/ParallelComm.hpp"
  #include "MBParallelConventions.h"
  #include "moab/Core.hpp"
+#include "FileOptions.hpp"
+#include "ReadParallel.hpp"



More information about the moab-dev mailing list