[MOAB-dev] ReadCGM question

[Steve Jackson]

In MOAB's ReadCGM.cpp, around line 490, there is the following check:


// edge is a CGM RefEdge
// start_vtx and end_vtx are RefVertices representing the start_vertex() and end_vertex() of edge
// points is a list of CubitVectors produced by calling get_graphics() on edge

      // check proximity of vertices to end coordinates
    if ((start_vtx->coordinates() - points.front()).length() > GEOMETRY_RESABS
     || (  end_vtx->coordinates() - points.back() ).length() > GEOMETRY_RESABS ) {
      std::cerr << "Warning: vertices not at ends of curve " << edge->id() << std::endl;
    }

This warning often produces large quantities of annoying messages.  (I have one geometry where it produces tens of thousands of lines of output when the file is loaded into MOAB.)  I want to fix this, but first wanted to check with others on the most correct fix.

* If this check is correct (i.e. users should be legitimately concerned by it), I propose to make the warning message print only up to ten times, with a summary of the number of suppressed warnings if more than that occur.

* I think it would it be more correct to replace GEOMETRY_RESABS with faceting_tol, i.e. the tolerance value that was used in calling edge->get_graphics().  Does anyone disagree?  

~S