[MOAB-dev] [Meshkit-dev] r3468 - MeshKit/trunk/algs

[Jason Kraftcheck]

After considering this further, I think it would be better if you were to do:
  #include "moab/GeomTopoTool.hpp"
  using moab::GeomTopoTool;

There are some classes that are part of the MOAB API that never had an 'MB'
prefix.  There was no obvious renaming scheme to use, so I left those
classes with their original names but moved then to the 'moab' namespace.  I
am hoping that these classes are seldom used outside of our group and thus
that the lack of compatibility headers will not trouble too many people.

My original suggestion that I add an "MBGeomTopoTool.hpp" header would have
been consistent with what is done for classes that were previously prefixed
with 'MB'.  However, after considering it, this didn't make sense to me.  We
are providing the old headers for compatibility purposes.  If the header has
a different name, it really isn't compatible with the old MOAB API.  So as
long as you need to change the #include anyway, you might as well change it
to use the namespaced one.

- jason



Hongjun Kim wrote:
> Thanks.
> 
> Hong-Jun
> 
> ----- Original Message -----
> From: "Jason Kraftcheck" <kraftche at cae.wisc.edu>
> To: "Hongjun Kim" <hongjun at mcs.anl.gov>
> Sent: Wednesday, March 17, 2010 3:48:40 PM GMT -06:00 US/Canada Central
> Subject: Re: [Meshkit-dev] r3468 - MeshKit/trunk/algs
> 
> Hongjun Kim wrote:
>> I need to include "GeomTopoTool.hpp" in meshkit cutcell mesher.
>> Can you make it installed moab install directory?
>>
> 
> I will create a new MBGeomTopoTool in the main directory.
> 
> - jason
> 
> 
> 
>> Hong-Jun
>>
>> ----- "Jason Kraftcheck" <kraftche at cae.wisc.edu> wrote:
>>
>>> hongjun at mcs.anl.gov wrote:
>>>> With updated moab and meshkit, I have some errors for "make check"
>>> in meshkit.
>>>> I added moab header file directory to include path because it is not
>>> set in "iMesh-Def.inc".
>>>
>>> Yes, but you shouldn't need to have that directory in your include
>>> path.
>>>
>>>> Since using "MBVertex in meshkit/algs/MergeMesh.cpp" also makes
>>> error, I added namespace moab.
>>> I'm working on a fix for this.
>>>
>>>> Do you think it is bad ways to fix "make check" problem?
>>>>
>>> If there is a problem with MOAB, working around the bugs rather than
>>> reporting and/or fixing them is not the best solution to such
>>> problems.
>>>
>>> - jason
> 
> 


-- 
"A foolish consistency is the hobgoblin of little minds" - Ralph Waldo Emerson