[MOAB-dev] Possible bug in MBParallelComm.cpp

[Tim Tautges]

The comment is wrong, we want the skin entities always, or at least at the present time.  I'd call that a side effect of 
resolving shared entities, so maybe that constraint could be relaxed eventually.

- tim

Roman Putanowicz wrote:
> Hi,
> 
> I looked at the code of MBParallelComm.cpp and noticed comment
> that (as far as I understand the code) does not go with the code:
> 
> Starting at the line 2812 there is fragment:
> 
> // get entities adjacent to skin ents from shared_dim down to
> // zero; don't create them if they don't exist already
>   for (int this_dim = skin_dim-1; this_dim >= 0; this_dim--) {
>        result = mbImpl->get_adjacencies(skin_ents[skin_dim], this_dim,
>                                         true, skin_ents[this_dim],
>                                         MBInterface::UNION);
>                                                                                             RRA("Failed getting skin adjacencies.");
>    }
> 
> The third argument to get_adjacencies function has the value 'true'.
> However the name of this argument is 'create_if_missing'
> 
> Is the code or comment wrong (or am I misunderstanding something) ?
> 
> Regards
> 
> Roman

-- 
================================================================
"You will keep in perfect peace him whose mind is
   steadfast, because he trusts in you."               Isaiah 26:3

              Tim Tautges            Argonne National Laboratory
          (tautges at mcs.anl.gov)      (telecommuting from UW-Madison)
          phone: (608) 263-8485      1500 Engineering Dr.
            fax: (608) 263-4499      Madison, WI 53706