[MOAB-dev] MBElemUtil

[Jason Kraftcheck]

David C Thompson wrote:
> Jason,
> 
> 	You've checked in some changes in the tools/mbcoupler directory that
> break the build for me. Specifically, findpt_test.cpp tries to declare
> variables of type MBElemUtil, but that is a namespace not a class. It
> generates these errors:
> 
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp: In function ‘void test_hex_findpt()’:
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp:19: error: expected primary-expression before ‘u’
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp:19: error: expected `;' before ‘u’
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp:44: error: ‘u’ was not declared in this scope
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp: In function ‘void test_nat_coords_trilinear_hex2()’:
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp:61: error: expected primary-expression before ‘u’
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp:61: error: expected `;' before ‘u’
> /usr/local/src/ANL/MOAB/HEAD-anon/tools/mbcoupler/findpt_test.cpp:75: error: ‘u’ was not declared in this scope
> 
> I have fixed things by simpling using the namespace prefix where
> appropriate but don't want to check it in if your real intention is to
> turn MBElemUtil into a struct or class. Was that your intention or
> should I check in my changes?

It was originally a class.  However, the class was only used to group static
member functions.  So I changed it to a namespace.  I checked in a fix for
the findpt_test.cpp issues.

- jason