[MOAB-dev] r1274 - MOAB/trunk

kraftche at mcs.anl.gov kraftche at mcs.anl.gov
Fri Sep 14 11:03:31 CDT 2007


Author: kraftche
Date: 2007-09-14 11:03:31 -0500 (Fri, 14 Sep 2007)
New Revision: 1274

Modified:
   MOAB/trunk/MBError.hpp
Log:
Remove static storage for message buffer
  - static sucks for multithreading 
  - its stack-allocated anyway (heap allocation is the expensive one)
  - if the error-reporting code is a performance-critical path, 
    we've got bigger issues


Modified: MOAB/trunk/MBError.hpp
===================================================================
--- MOAB/trunk/MBError.hpp	2007-09-14 16:01:06 UTC (rev 1273)
+++ MOAB/trunk/MBError.hpp	2007-09-14 16:03:31 UTC (rev 1274)
@@ -72,7 +72,7 @@
   
   MBErrorCode set_last_error( const char* fmt, va_list args )
   {
-    static char text[1024];
+    char text[1024];
     VSNPRINTF( text, sizeof(text), fmt, args );
     mLastError = text;
     return MB_SUCCESS;




More information about the moab-dev mailing list