[MOAB-dev] r1335 - MOAB/trunk

David C Thompson dcthomp at sandia.gov
Wed Oct 24 17:40:45 CDT 2007


> Why did you add HDF5-related defines to MBEntityHandle.h.in?  The
> MBEntityHandle header has nothing to do with HDF5 files.
Well, my Mom always taught me never to use a C compiler's "-D" option --
that's what config files are for. But MOAB seems hopelessly tied to the
idea so I'll change it back.

> I don't think we use config.h anywhere (it will probably break
> applications if ever used in a MOAB header anyway.)  Tools like automake
> and autoreconf insist on generating at least one such header automatically
> using autoheader, so we just let it generate the header and never use it.
OK.

	David




More information about the moab-dev mailing list