[Darshan-commits] [Git][darshan/darshan][master] bug fix in agg_perf_by_slowest perf calculation

[Shane Snyder]

Shane Snyder pushed to branch master at darshan / darshan


Commits:
5e1a0963 by Shane Snyder at 2016-05-16T14:20:38-05:00
bug fix in agg_perf_by_slowest perf calculation

this calculation was inadvertently accounting for metadata time
twice. also, clarified timing descriptions for slowest unique
file perf calculations.

- - - - -


2 changed files:

- darshan-util/darshan-parser.c
- darshan-util/doc/darshan-util.txt


Changes:

=====================================
darshan-util/darshan-parser.c
=====================================
--- a/darshan-util/darshan-parser.c
+++ b/darshan-util/darshan-parser.c
@@ -558,7 +558,7 @@ int main(int argc, char **argv)
             printf("# I/O timing for unique files (seconds):\n");
             printf("# ...........................\n");
             printf("# unique files: slowest_rank_io_time: %lf\n", pdata.slowest_rank_time);
-            printf("# unique files: slowest_rank_meta_time: %lf\n", pdata.slowest_rank_meta_time);
+            printf("# unique files: slowest_rank_meta_only_time: %lf\n", pdata.slowest_rank_meta_time);
             printf("# unique files: slowest rank: %d\n", pdata.slowest_rank_rank);
             printf("#\n");
             printf("# I/O timing for shared files (seconds):\n");
@@ -1350,7 +1350,6 @@ void calc_perf(perf_data_t *pdata,
     if (pdata->slowest_rank_time + pdata->shared_time_by_slowest)
     pdata->agg_perf_by_slowest = ((double)pdata->total_bytes / 1048576.0) /
                                      (pdata->slowest_rank_time +
-                                      pdata->slowest_rank_meta_time +
                                       pdata->shared_time_by_slowest);
 
     return;


=====================================
darshan-util/doc/darshan-util.txt
=====================================
--- a/darshan-util/doc/darshan-util.txt
+++ b/darshan-util/doc/darshan-util.txt
@@ -394,7 +394,7 @@ Job performance information can be generated using the `--perf` command-line opt
 # I/O timing for unique files (seconds):
 # ...........................
 # unique files: slowest_rank_io_time: 0.000000
-# unique files: slowest_rank_meta_time: 0.000000
+# unique files: slowest_rank_meta_only_time: 0.000000
 # unique files: slowest_rank: 0
 #
 # I/O timing for shared files (seconds):
@@ -430,7 +430,7 @@ type of file access.
 
 * unique files: slowest_rank_io_time: total I/O time for unique files
   (including both metadata + data transfer time)
-* unique files: slowest_rank_meta_time: metadata time for unique files
+* unique files: slowest_rank_meta_only_time: metadata time for unique files
 * unique files: slowest_rank: the rank of the slowest process
 
 .I/O timing for shared files



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/commit/5e1a0963a498aebfa583d4b653561f1fd29c6b59
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20160516/6735f004/attachment.html>