[petsc-dev] [petsc-checkbuilds] PETSc blame digest (next) 2016-04-08

[Barry Smith]

  huh, I don't see your changes being relevant. I don't think you should push them.

> On Apr 8, 2016, at 11:39 AM, Satish Balay <balay at mcs.anl.gov> wrote:
> 
> [Checking this for Emil]
> 
> Its not clear why this warning is coming up. The following fixes
> it. (not sure if its a workarround or a fix)
> 
> Any objections to pushing?
> 
> thanks,
> Statish
> -------------
> diff --git a/src/ts/impls/explicit/rk/rk.c b/src/ts/impls/explicit/rk/rk.c
> index e3d106f..dfe3de9 100644
> --- a/src/ts/impls/explicit/rk/rk.c
> +++ b/src/ts/impls/explicit/rk/rk.c
> @@ -566,7 +566,6 @@ static PetscErrorCode TSAdjointStep_RK(TS ts)
>   PetscFunctionBegin;
>   t          = ts->ptime;
>   rk->status = TS_STEP_INCOMPLETE;
> -  h = ts->time_step;
>   ierr = TSPreStep(ts);CHKERRQ(ierr);
>   for (i=s-1; i>=0; i--) {
>     rk->stage_time = t + h*(1.0-c[i]);
> @@ -772,6 +771,7 @@ static PetscErrorCode TSSetUp_RK(TS ts)
>   }
>   if (!rk->tableau) {
>     ierr = TSRKSetType(ts,TSRKDefault);CHKERRQ(ierr);
> +    rk = (TS_RK*)ts->data;
>   }
>   tab  = rk->tableau;
>   s    = tab->s;
> @@ -937,6 +937,7 @@ PetscErrorCode  TSRKGetType_RK(TS ts,TSRKType *rktype)
>   PetscFunctionBegin;
>   if (!rk->tableau) {
>     ierr = TSRKSetType(ts,TSRKDefault);CHKERRQ(ierr);
> +    rk = (TS_RK*)ts->data;
>   }
>   *rktype = rk->tableau->name;
>   PetscFunctionReturn(0);
> 
> 
> On Fri, 8 Apr 2016, PETSc checkBuilds wrote:
> 
>> 
>> 
>> Dear PETSc developer,
>> 
>> This email contains listings of contributions attributed to you by
>> `git blame` that caused compiler errors or warnings in PETSc automated
>> testing.  Follow the links to see the full log files. Please attempt to fix
>> the issues promptly or let us know at petsc-dev at mcs.anl.gov if you are unable
>> to resolve the issues.
>> 
>> Thanks,
>>  The PETSc development team
>> 
>> ----
>> 
>> warnings attributed to commit https://bitbucket.org/petsc/petsc/commits/f68a32c
>> Implemented the renovated RK.
>> 
>>  src/ts/impls/explicit/rk/rk.c:775
>>    [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-linux-analyzer_crush.log]
>>      /sandbox/petsc/petsc.clone/src/ts/impls/explicit/rk/rk.c:775:10: warning: Access to field 's' results in a dereference of a null pointer (loaded from variable 'tab')
>> 
>>  src/ts/impls/explicit/rk/rk.c:939
>>    [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-linux-analyzer_crush.log]
>>      /sandbox/petsc/petsc.clone/src/ts/impls/explicit/rk/rk.c:939:13: warning: Access to field 'name' results in a dereference of a null pointer (loaded from field 'tableau')
>> 
>> ----
>> To opt-out from receiving these messages - send a request to petsc-dev at mcs.anl.gov.
>> 
>