[petsc-dev] configure tetgen error

[Barry Smith]

> On Jan 13, 2015, at 9:48 PM, Satish Balay <balay at mcs.anl.gov> wrote:
> 
> On Tue, 13 Jan 2015, Satish Balay wrote:
> 
>> Will push to barry/namespace-install [and merge to master/next]
> 
> However 'next' gives the following error.
> 
>>>>>>>>> 
> home/balay/petsc/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c: In function ‘SNESLineSearchApply_NLEQERR’:
> /home/balay/petsc/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c:111:10: error: ‘true’ undeclared (first use in this function)
>   while (true) {
>          ^
> /home/balay/petsc/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c:111:10: note: each undeclared identifier is reported only once for each function it appears in
> gmakefile:161: recipe for target 'arch-next-ctetgen/obj/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.o' failed
> <<<<<<<<<
> 
> So the following fix?
> 
>>>>>>>>>>>>>> 
> $ git diff |cat
> diff --git a/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c b/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c
> index c275d9a..1b80b85 100644
> --- a/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c
> +++ b/src/snes/linesearch/impls/nleqerr/linesearchnleqerr.c
> @@ -108,7 +108,7 @@ static PetscErrorCode  SNESLineSearchApply_NLEQERR(SNESLineSearch linesearch)
>      At the end of this while loop, G should have the accepted new X in it. */
> 
>   count = 0;
> -  while (true) {
> +  while (PETSC_TRUE) {
>     if (monitor) {
>       ierr = PetscViewerASCIIAddTab(monitor,((PetscObject)linesearch)->tablevel);CHKERRQ(ierr);
>       ierr = PetscViewerASCIIPrintf(monitor,"    Line search: entering iteration with lambda: %14.12e\n", lambda);CHKERRQ(ierr);
> <<<<<<<<<
> 
> But which branch does this fix go to? I don't see this branch in petsc
> repo. I see Matt merged this to master

   WTF? And I thought I was quick to get into master. It never passed the nightly so certainly didn't belong in master yet.

   This was a pull request. 

  Barry

> - so will leave it to
> Matt/Patrick to resolve..
> 
> Satish
> 
> ----------
> 
> $ git branch -r --contains d4c6564c
>  origin/next
> 
> 
> commit 2e51616568b6d7c20fc05db6793a1a176d001d82
> Merge: f0fa725 d4c6564
> Author: Matthew G. Knepley <knepley at gmail.com>
> Date:   Tue Jan 13 12:57:14 2015 -0600
> 
>    Merge branch 'pefarrell/linesearch-nleqerr' into next
> 
>    * pefarrell/linesearch-nleqerr:
>      Implement the NLEQ-ERR linesearch of Deuflhard (2011).
> 
> 
> commit d4c6564c171d7f6bffed680177fba1cf86876815
> Author: Patrick Farrell <patrick.farrell at imperial.ac.uk>
> Date:   Sun Jan 11 21:26:19 2015 +0000
> 
>    Implement the NLEQ-ERR linesearch of Deuflhard (2011).