[petsc-dev] why is there a #requirespackage 'PETSC_HAVE_PCBDDC'

Barry Smith bsmith at mcs.anl.gov
Mon Mar 4 18:25:55 CST 2013


On Mar 4, 2013, at 6:22 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> 
> On Mon, Mar 4, 2013 at 6:16 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> Why is there a    #requirespackage 'PETSC_HAVE_PCBDDC'   ?
> 
> Having things like this means that when someone is updating code globally changes to locations like these do not get tested before being pushed and hence is likely broken.
> 
>    That directory appears to depend on PARMETIS so should have that dependency listed in the makefile instead
> 
> IIRC, the code does not work with complex either.

    The makefile should be marked as not supporting complex

> It was put into the repository mostly because we don't have a good system for supporting forks.\
   
   I thought bitbucket now gives a system for handling forks?

> It was off by default because the code was unstable and untested. There is an example now (src/ksp/ksp/examples/tutorials/ex59.c) so I think we can remove the --with-pcbddc option. Stefano, does this sound right to you?

   Or it could be a good test example for a PETSc plugin repository?

   Barry





More information about the petsc-dev mailing list