[petsc-dev] windows fixes.

Barry Smith bsmith at mcs.anl.gov
Fri Jun 28 12:20:37 CDT 2013


   Boy those decorators sure saved you a lot of code below. I cannot imagine how anyone actually wrote code using python 2.4 without decorators, the code must have been so long that it constantly filled the entire filesystem and everyone's hands were so tired from typing. Thank god for decorators!

   Barry



On Jun 28, 2013, at 10:45 AM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> Barry Smith <bsmith at mcs.anl.gov> writes:
> 
>>  Clumsy code it is :-)
> 
> Fixed in 'next'.
> 
> commit 96c122f7ff11b2781a634ef7c59f013fab739c6b (jed/config-cleanup)
> Author: Jed Brown <jedbrown at mcs.anl.gov>
> Date:   Fri Jun 28 10:39:37 2013 -0500
> 
>    config: python-2.4 does not support decorators
> 
>    This amends 2a571ffb5945aee7 to avoid decorators.
> 
> diff --git a/config/BuildSystem/config/setCompilers.py b/config/BuildSystem/config/setCompilers.py
> index a7c1507..0b3325c 100644
> --- a/config/BuildSystem/config/setCompilers.py
> +++ b/config/BuildSystem/config/setCompilers.py
> @@ -124,8 +124,6 @@ class Configure(config.base.Configure):
>     return 0
>   isNAG = staticmethod(isNAG)
> 
> -  @staticmethod
> -  @config.memoize
>   def isGNU(compiler):
>     '''Returns true if the compiler is a GNU compiler'''
>     try:
> @@ -148,6 +146,7 @@ class Configure(config.base.Configure):
>     except RuntimeError:
>       pass
>     return 0
> +  isGNU = staticmethod(config.memoize(isGNU))
> 
>   def isClang(compiler):
>     '''Returns true if the compiler is a Clang/LLVM compiler'''




More information about the petsc-dev mailing list