[petsc-dev] anyone feel like fixing a bug?

[Jed Brown]

On Wed, May 23, 2012 at 8:36 AM, Barry Smith <bsmith at mcs.anl.gov> wrote:

>
> On May 22, 2012, at 9:32 PM, Jed Brown wrote:
>
> > Well, here's the problem:
> >
> > MatSetBlockSize() used to call mat->ops->setblocksize() which the MPI
> matrices forwarded down to their seq submatrices.
> >
> > But then this patch removed that behavior so MatSetBlockSize() is
> processed immediately and not forwarded down.
> >
> > http://petsc.cs.iit.edu/petsc/petsc-dev/rev/80ec81eb9db9
> >
> > Since the Seq inner matrices have different PetscLayouts, they don't
> inherit the block sizes set on their parent.
> >
> > Barry, why did you remove this MatOp? How do you want the MPI matrices
> to forward block sizes now?
>
>    Blocksize is now suppose to be known "early" now. That is, you cannot
> change it after MatSetUp() is called. It is the job of each matrix
> implementation to use the already set block size in the appropriate way.
> Generally this means before the "Seq" matrices are created or finalized.
>  One could possible arrange moving the blocksize information down during
> the MatSetUp() of that implementation or the MatXXXXSetPreallocation() or
> when the inner Mat objects are created.
>
>    If you tell me the EXACT change of events of the "inner" block size not
> being set properly I can take a look at it.
>

This is EXACTLY where the inner blocks now need to be set. ;-)

http://petsc.cs.iit.edu/petsc/petsc-dev/rev/0bb703470caa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120523/9b079114/attachment.html>