[petsc-dev] Barry, why would you do such a thing?

Barry Smith bsmith at mcs.anl.gov
Wed Jan 18 12:49:20 CST 2012


On Jan 18, 2012, at 10:15 AM, Jed Brown wrote:

> On Thu, Jan 5, 2012 at 11:21, Jed Brown <jedbrown at mcs.anl.gov> wrote:
> http://petsc.cs.iit.edu/petsc/petsc-dev/rev/3e8229e78095
> 
> I'm having trouble understanding the justification that you gave in the commit message...
> 
> Also, that comment format is not allowed in PETSc code.
> 
> So now Peter has fixed the comment syntax in (http://petsc.cs.iit.edu/petsc/petsc-dev/rev/113ebf3872d3), but we still have this confusing fragment of dead code floating around. Is the error handler really not supposed to be set? Was this a debugging fragment that never should have been committed?

    Debugging fragment that should never been committed. I wanted more information from MPI about the problem it detected then was traditionally available. Maybe when the option -on_error_abor it used it should not set this MPI property?

     Uncomment the line

    Barry


> What's going on here? (I want to either delete the line or uncomment it.)




More information about the petsc-dev mailing list