[petsc-dev] PCCreate_BFBt has no manual page

Barry Smith bsmith at mcs.anl.gov
Thu Mar 17 10:10:31 CDT 2011


  Remove it. Dead code is a sin.

   Barry

On Mar 17, 2011, at 9:09 AM, Jed Brown wrote:

> On Sun, Feb 27, 2011 at 18:15, Barry Smith <bsmith at mcs.anl.gov> wrote:
> This exact text could go into the manual page. The problem now is that this information is in only one location (your head) and no one else knows if
> 1) BFBt is orthogonal to to lsc
> 2) BFBt is the replacement to lsc
> 3) BFBt is to be replaced with lsc.
> without consulting you.
> 
> Dave knows. :-)
> 
> Indeed, he just did the real work here and put in the MatNest support so that the BFBt methods from his paper now run with LSC and produces identical results. This has been merged into petsc-dev.
> 
> About this example, it's quite a hard problem and pretty small (32x32 Q1-P0 elements), but the matrices come from Underworld which we can't easily include in a test. I'm inclined to put the matrix into datafiles and add the test to the nightlies since it seems to be a discerning preconditioner benchmark.
> 
> Now about whether to delete PCBFBT now or leave it around. I don't see a problem with adding a man page that puts it in the "developer" level and has a note that it is deprecated and LSC should be used instead, with a link to this example for details on converting code.




More information about the petsc-dev mailing list