[petsc-dev] Problem with latest "petsc-dev" change

[Bobby Philip]

If I do it again I'll make sure I send you the logs..

On Nov 4, 2010, at 10:56 AM, Satish Balay wrote:

> On Thu, 4 Nov 2010, Bobby Philip wrote:
> 
>> Satish:
>> 
>> 
>> On Nov 4, 2010, at 12:11 AM, Satish Balay wrote:
>> 
>>> On Wed, 3 Nov 2010, Bobby Philip wrote:
>>> 
>>>> As far as I can tell SAMRAI uses petsc assuming the C style calls
>>>> for petsc.
>>> 
>>> Yeah - the issue comes up when building PETSc with a c compiler - and
>>> then compiling user code [in this case SAMRAI] that includes petsc.h
>>> with c++ compiler.
>>> 
>> 
>> Is this just an extern C type issue?
> 
> No the issue was: there is a macro [petsc includes] that are
> compiler-feature specific.  If PETSc is configured with a C compiler -
> that was tested for feature. [but the c++ compiler was not tested]
> 
> But SAMRAI was compiled with c++ - so this flag was missing - and the
> macro barfed. Now we always set a default flag for c++ - so the macro
> doesn't barf..
> 
>>>> In cases where I have enabled C++ in PETSc it has broken
>>>> SAMRAI.
>>> 
>>> Are compiles broken or runs broken? If its compiles - perhaps its just
>>> a matter of correct #defines [managing c/c++ lang when including
>>> petsc?]
>>> 
>> 
>> Compiles are broken...as far as I remember - but it's been a while.
> 
> Well if you retry and see issues - we can take a look at the logs..
> 
> Satish