release-3.0.0 broken for C++ builds

[Barry Smith]

   Sorry, fixed.

   Say, isn't it about time we abolish PetscTruth? Are the C and C++  
bool compatible with each other and compatible with Fortran 90's  
logical?

    Barry

On Jul 20, 2009, at 12:51 PM, Lisandro Dalcin wrote:

> Barry, this time you are the guy to blame ;-) (at least for the push)
>
> All these lines like below in src/mat/impls/aij/mpi/mpiaij.c are
> wrong, you do not have implicit bool -> enum in C++.
>
> MatStashValuesXXX_Private(...., ignorezeroentries && (addv ==  
> ADD_VALUES))
>
>
> libfast in: /usr/local/petsc/3.0.0/src/mat/impls/aij/mpi
> mpiaij.c: In function PetscErrorCode MatSetValues_MPIAIJ(_p_Mat*,
> PetscInt, const PetscInt*, PetscInt, const PetscInt*, const
> PetscScalar*, InsertMode):
> mpiaij.c:396: error: cannot convert bool to PetscTruth for argument 6
> to PetscErrorCode MatStashValuesRow_Private(MatStash*, PetscInt,
> PetscInt, const PetscInt*, const PetscScalar*, PetscTruth)
> mpiaij.c:398: error: cannot convert bool to PetscTruth for argument 7
> to PetscErrorCode MatStashValuesCol_Private(MatStash*, PetscInt,
> PetscInt, const PetscInt*, const PetscScalar*, PetscInt, PetscTruth)
> mpiaij.c: In function void matsetvaluesmpiaij_(_p_Mat**, PetscInt*,
> const PetscInt*, PetscInt*, const PetscInt*, const PetscScalar*,
> InsertMode*, PetscErrorCode*):
> mpiaij.c:5242: error: cannot convert bool to PetscTruth for argument 6
> to PetscErrorCode MatStashValuesRow_Private(MatStash*, PetscInt,
> PetscInt, const PetscInt*, const PetscScalar*, PetscTruth)
> mpiaij.c:5244: error: cannot convert bool to PetscTruth for argument 7
> to PetscErrorCode MatStashValuesCol_Private(MatStash*, PetscInt,
> PetscInt, const PetscInt*, const PetscScalar*, PetscInt, PetscTruth)
>
>
> -- 
> Lisandro Dalcín
> ---------------
> Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
> Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
> Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> Tel/Fax: +54-(0)342-451.1594