[Swift-devel] 0.7rc1 + local coasters + communicado

Ben Clifford benc at hawaga.org.uk
Wed Nov 5 14:36:49 CST 2008


The below one-liner seems to fix hanging on my laptop. I didn't commit in 
case I'm missing something in the logic, but I think its ok:


--- 
src/org/globus/cog/abstraction/impl/execution/local/JobSubmissionTaskHandler.java   
(revision 2257)
+++ 
src/org/globus/cog/abstraction/impl/execution/local/JobSubmissionTaskHandler.java   
(working copy)
@@ -342,6 +342,7 @@
                 boolean any = processPairs();
                 if (processDone()) {
                     closePairs();
+                    return;
                 }
                 else {
                     if (!any) 



Also, though I don't see that it would cause a lock, this looks wrong:

                int avail = sp.is.available();
                if (avail > 0) {
                    any = true;
                    int len = sp.is.read();
                    sp.os.write(buf, 0, len);
                }


InputStream.read() with no parameter returns the read byte, not a buffer 
length. read(buf, offset, len) is perhaps what is intended - I think at 
present its going to send out big wads of empty space instead of stream 
content.

Also, I was wrong about it passing on the nmi buid and test system - that 
test is still queued to run at the moment.


-- 



More information about the Swift-devel mailing list