[petsc-dev] have requests for MR review indicate time expected to complete

Satish Balay balay at mcs.anl.gov
Wed May 25 11:06:12 CDT 2022

On Wed, 25 May 2022, Matthew Knepley wrote:

> On Wed, May 25, 2022 at 11:55 AM Barry Smith <bsmith at petsc.dev> wrote:
> >
> >   It would be nice if when people received MR review requests it indicated
> > if the review was trivial and could be done in a minute or two. Then maybe
> > quick ones could flow through the system faster.
> >
> >   How do people 1) know first when they have things they should (or have
> > been asked to) review and 2) know the list of things they should review at
> > any point in time. I am interested in other people's work flows to see if I
> > should adjust mine.
> I get emails for review, but it would be nice if there was a dashboard at
> Gitlab where we could see what is pending for us.


You can easily access this via the options on the top-right (along with issues, todo-list)

> Is there a way to indicate if a review is trivial or long?

Perhaps the author could add some text wrt what parts the reviewer should pay extra attention to.

However who would evaluate if the review is trivial or long? Even if the author thinks its trivial - the reviewer might evaluate it differently.

One related issue is - some MRs pack in way too many changes - where multiple MRs would be more appropriate. [and easier to review - as now some of them could be trivial - and others require more thought]


More information about the petsc-dev mailing list