[petsc-dev] Test parsing

Matthew Knepley knepley at gmail.com
Thu Oct 28 08:12:52 CDT 2021


I just found a loophole in the test parsing happening here:

  https://gitlab.com/petsc/petsc/-/blob/main/config/testparse.py#L530

If your file was produced on Windows (CRLF), then the parsing fails and
tests
are silently ignored. This took me some time to find and could be confusing
for others. I think we should either:

  a) Fix the parser to work with CRLF as well

or

  b) Fail immediately for CRLF files

What do you think?

  Thanks,

     Matt

-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener

https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20211028/ae165e95/attachment.html>


More information about the petsc-dev mailing list