[petsc-dev] Master broken after changes to PetscSection headers

[Stefano Zampini]

How come this was not caught by the tests? I think we have tests with
-Werror

Il Gio 19 Set 2019, 12:15 Lisandro Dalcin via petsc-dev <
petsc-dev at mcs.anl.gov> ha scritto:

> The warnings below are from a C build. A C++ build fails right away.
>
> We need to `#include <petscsection.h>` somewhere in the public headers, at
> least such that  `#include <petsc.h>` in user code works.
>
> $ git grep petscsection include/
> include/petsc/private/sectionimpl.h:#include <petscsection.h>
> include/petscis.h:#include <petscsectiontypes.h>
> include/petscsection.h:#include <petscsectiontypes.h>
>
>
> /home/devel/petsc/dev/src/snes/utils/convest.c: In function
> ‘PetscConvEstGetConvRate’:
> /home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit
> declaration of function ‘PetscSectionGetField’; did you mean
> ‘PetscSectionVecView’? [-Wimplicit-function-declaration]
>   293 |       ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr);
>       |              ^~~~~~~~~~~~~~~~~~~~
>       |              PetscSectionVecView
> /home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit
> declaration of function ‘PetscSectionGetConstrainedStorageSize’
> [-Wimplicit-function-declaration]
>   294 |       ierr = PetscSectionGetConstrainedStorageSize(fs,
> &lsize);CHKERRQ(ierr);
>       |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> --
> Lisandro Dalcin
> ============
> Research Scientist
> Extreme Computing Research Center (ECRC)
> King Abdullah University of Science and Technology (KAUST)
> http://ecrc.kaust.edu.sa/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20190919/0d5eb30f/attachment.html>