[petsc-dev] "participants" on gitlab

Zhang, Hong hongzhang at anl.gov
Wed Oct 30 17:08:44 CDT 2019

After some discussion with Satish, I realized that currently the approval rules default to Integration, Team and Code Owner and all these groups are carried over as participants for MRs. It is reasonable to keep integrators and codeowners in the list since they should definitely look at the MR. But I would suggest to remove Team from the default. Actually the codeowners/integrators can edit the MR page and add other people to the approval list if needed. If we need to encourage more people to review, adding them to codeowners would be much better than abusing Team. To solve the notification problem, I considered to be removed from Team, but that would cause me to lose the privileges. I think removing Team from default and relying more on codeowners would solve the notification problem perfectly.

Hong (Mr.)

> On Oct 21, 2019, at 10:34 AM, Jed Brown <jed at jedbrown.org> wrote:
> All "developers" are listed as able to grant (optional) approvals --
> approval from codeowners/integrators is still needed regardless of those
> optional approvals.  We should perhaps remove that because I don't know
> a way to have some able to approve without the notification problem you
> mention below.  Unfortunately, I think that reduces incentive to review,
> and we're always stressed for reviewing resources.
> "Zhang, Hong via petsc-dev" <petsc-dev at mcs.anl.gov> writes:
>> How is the list of participants determined when a MR is created on gitlab? It seems to include everybody by default. Is there any way to shorten the list? Ideally only the participants involved in the particular MR should be picked. Note that currently there is a huge gap between the ''Participate'' and ''On mention'' levels in the notification settings. With the former, I get spammed with notifications whenever a new MR is created. With the later, I won’t receive any notification (even someone replied my comments) unless explicitly @ by someone.
>> Hong (Mr.)

More information about the petsc-dev mailing list