[petsc-dev] Our pull request work flow is terrible and horrible

Smith, Barry F. bsmith at mcs.anl.gov
Fri Jan 12 18:01:15 CST 2018



> On Jan 12, 2018, at 5:47 PM, Jed Brown <jed at jedbrown.org> wrote:
> 
> Patrick Sanan <patrick.sanan at gmail.com> writes:
> 
>>>   Hmm, now there are two things to keep track of for each pull request
>>> (the pull request web page and the issue web page) so you've doubled the
>>> pain just so you can use the bitbucket issue assigner to know who is
>>> assigned to it.
>>> 
>> I meant to suggest to do this only for "not actively trying to merge" PRs
>> that you want to take off the PR page and convert to issues.
> 
> FWIW, GitHub pull requests can be assigned and also track which named
> reviewers have entered reviews.  Users can also get a unified summary of
> review requests and assigned issues/PRs across all projects.
> 
> https://github.com/pulls/review-requested
> https://github.com/pulls/assigned

   Sadly you cannot reply to previous comments for Github PRs, there is just a mass of unorganized previous comments. If this is fixed then Github becomes more desirable looking.




More information about the petsc-dev mailing list