[petsc-dev] please don't mess up master by moving broken shit into

Smith, Barry F. bsmith at mcs.anl.gov
Wed Oct 25 11:34:19 CDT 2017


  Thanks


> On Oct 25, 2017, at 11:22 AM, Hong <hzhang at mcs.anl.gov> wrote:
> 
> This should be cleaned by 
> https://bitbucket.org/petsc/petsc/commits/a0d1c92d1d6734b184005d635c14bf9895961849
> 
> Will merge it to master once it passes nightly tests.
> 
> Hong
> 
> On Tue, Oct 24, 2017 at 10:41 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> 
> ftp://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2017/10/02/examples_full_master.log
> 
> ftp://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2017/10/03/examples_full_master.log
> 
> Clearly this was broken in next on
> 
> ftp://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2017/10/02/examples_full_next.log
> 
> so how the hell did it get into master? If next is broken, you don't move branches to master!
> 
> Now someone has to go back and log into some obscure machine and figure out the commit that broke things and fix it.
> 
> Please be considerate of Satish and others who have to fix crap you put into master by making sure you don't move broken shit into master.
> 
> Yes eventually we'll get rid of the nightmare of next but until then please don't put broken shit in master because you "think" it is not the problem!
> 
> And yes we need to finish the test harness so next is rightfully killed! But that will take some time.
> 
> 
> 
> 
> 
> 
> 



More information about the petsc-dev mailing list