[petsc-dev] Some warnings in Master branch

[Jed Brown]

Matthew Knepley <knepley at gmail.com> writes:

> On Mon, Jun 5, 2017 at 11:29 AM, Zhang, Hong <hongzhang at anl.gov> wrote:
>
>> The first one looks like a bug.
>>
>> CC-128 craycc: WARNING File = /global/u2/h/hongzh/Project/
>> petsc/src/dm/impls/plex/plextree.c, Line = 3149
>>   The indicated loop is not reachable from preceding code.
>>           SETERRQ(PETSC_COMM_SELF,PETSC_ERR_SUP,"Unsupported
>> discretization object");CHKERRQ(ierr);
>>
>
> Please describe why it looks like a bug:
>
>       if (classId == PETSCFE_CLASSID) {
>         ierr = PetscFEGetDualSpace((PetscFE)disc,&dsp);CHKERRQ(ierr);
>       }
>       else if (classId == PETSCFV_CLASSID) {
>         ierr = PetscFVGetDualSpace((PetscFV)disc,&dsp);CHKERRQ(ierr);
>       }
>       else {
>         SETERRQ(PETSC_COMM_SELF,PETSC_ERR_SUP,"Unsupported discretization
> object");CHKERRQ(ierr);

You should not have the unreachable CHKERRQ(ierr) sitting here after the
SETERRQ.

>       }
>
>   Thanks,
>
>     Matt
>
>
>> ftn-1279 crayftn: WARNING TSADAPTEQUALS, File =
>> ../../../global/u2/h/hongzh/Project/petsc/src/ts/f90-mod/petsctsmod.F,
>> Line = 66, Column = 32
>>   Procedure "TSADAPTEQUALS" is defined at line 32
>> (/global/u2/h/hongzh/Project/petsc/src/ts/f90-mod/petsctsmod.F).  The
>> type of this argument does not agree with dummy argument "A".
>>
>> ftn-1279 crayftn: WARNING TSADAPTEQUALS, File =
>> ../../../global/u2/h/hongzh/Project/petsc/src/ts/f90-mod/petsctsmod.F,
>> Line = 66, Column = 34
>>   Procedure "TSADAPTEQUALS" is defined at line 32
>> (/global/u2/h/hongzh/Project/petsc/src/ts/f90-mod/petsctsmod.F).  The
>> type of this argument does not agree with dummy argument "B".
>>
>> Hong (Mr.)
>
>
>
>
> -- 
> What most experimenters take for granted before they begin their
> experiments is infinitely more interesting than any results to which their
> experiments lead.
> -- Norbert Wiener
>
> http://www.caam.rice.edu/~mk51/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20170605/ff00f45b/attachment.sig>