[petsc-dev] TS failures in master

[Lisandro Dalcin]

On 29 April 2017 at 21:26, Barry Smith <bsmith at mcs.anl.gov> wrote:
>
>   Lisandro,
>
>    Even though it may be "irrelevant" it could be/is confusing to users to sometimes have something printed and sometimes not. They may conclude that there is a bug or misunderstand the output due to this by concluding there probably is some bound, it is just not being printed.
>

Barry, in my PR #699, the only subtype that will print nothing is
TSADAPTNONE. I wrote things so licence noise for that particular
subtype which does, well, nothing... All the other controllers use and
print the dt_min/dt_max values.

Now my PR got outdated, I'been waiting for

>    An alternative to not printing any thing when 0 is to print a different message indicating no clipping, for example something like
>
>>> if (adapt->dt_min > 0) {
>>>   ierr = PetscViewerASCIIPrintf(viewer,"  minimum allowed timestep %g\n",(double)adapt->dt_min);CHKERRQ(ierr);
>>> } else {
>       ierr = PetscViewerASCIIPrintf(viewer,"  no minimum on the allowed timestep\n");CHKERRQ(ierr);
> }
>

What kind of useful information would that provide with you run with
-ts_adapt_type none ? And as I said above, this is the only case where
the min/max dt (as well as safety factors,etc.) is silenced.


>    So if you really don't want to have it print the 0 or the MAX please use this construct for clarity. Is that reasonable?
>

Now my PR got outdated, I'been waiting for Toby to merge another, but
this has not happened yet.

@Satish Once I merge PR 699 I'll revert some of your changes to the
View() method. Then we can discuss the whole thing again.

-- 
Lisandro Dalcin
============
Research Scientist
Computer, Electrical and Mathematical Sciences & Engineering (CEMSE)
Extreme Computing Research Center (ECRC)
King Abdullah University of Science and Technology (KAUST)
http://ecrc.kaust.edu.sa/

4700 King Abdullah University of Science and Technology
al-Khawarizmi Bldg (Bldg 1), Office # 0109
Thuwal 23955-6900, Kingdom of Saudi Arabia
http://www.kaust.edu.sa

Office Phone: +966 12 808-0459