[petsc-dev] Hijacked MPI calls...

[Barry Smith]

  Satish,

   Interesting. We can probably get rid of most of the other warnings easily; it looks like mostly frivolous use of the , notation.

   Barry

> On Sep 12, 2016, at 11:19 PM, Satish Balay <balay at mcs.anl.gov> wrote:
> 
> The attached patch gets rid of most of the warnings [esp MPI usage
> from PETSc code - with the logging wrappers].
> 
> [also added to balay/clang-Wcomma]
> 
> Satish
> 
> On Mon, 12 Sep 2016, Satish Balay wrote:
> 
>> ok - so you are using CFLAGS=-Wcomma on your build..
>> 
>> I see warnings now. Attaching make.log
>> 
>> Satish
>> 
>> On Mon, 12 Sep 2016, Eric Chamberland wrote:
>> 
>>> 
>>> 
>>> Le 2016-09-12 à 17:32, Satish Balay a écrit :
>>>> Do you get these warnings with PETSc library build aswell?
>>> I can't tell since I didn't tried to build PETSc with clang...
>>>> 
>>>> The logging code tries to log all messages in library and in
>>>> application - and prints a summary with -info.
>>>> 
>>>> You can disable logging in your build with configure option: --with-log=0
>>>> 
>>>> Or you can define the PETSC_HAVE_BROKEN_RECURSIVE_MACRO in your
>>>> code/compile - and the wrappers will be skipped..
>>> ok, so these may be good workaround for me to keep -Wcomma activated on our
>>> "push server" that filters incoming commits...
>>> 
>>> Thanks!!!
>>> 
>>> Eric
>>> 
>>> 
>>> 
>> 
> <clang-Wcomma.patch><make.log>