[petsc-dev] [Bitbucket] Pull request #375: Pass LDFLAGS down to GNUPackage externalpackages. (petsc/petsc)

[Barry Smith]

   Hmm, we shouldn't be passing that flag to the linker anywhere, right? How does the linker even know about it?

   Barry

> On Oct 9, 2015, at 1:48 PM, Satish Balay <balay at mcs.anl.gov> wrote:
> 
> 
>> LDFLAGS="-Wall -Wwrite-strings -Wno-strict-aliasing -Wno-unknown-pragmas -Qunused-arguments -g3"
> 
> Wrt clang+gfortran - the trigger is: -Qunused-arguments [which is a
> clang flag - that gets passed to flinker aswell?]
> 
> balay at es^~/junk $ gfortran -Qunused-arguments cmd.f
> gfortran: error: unrecognized command line option ‘-Qunused-arguments’
> balay at es^~/junk $ 
> 
> Satish
> 
> 
> On Fri, 9 Oct 2015, Barry Smith wrote:
> 
>> 
>>   Well that's what the tests are for, to find such problems.
>> 
>>   Perhaps it should not be in GNUPackage but only in the individual xxx.py packages that require it? But how do we know which packages need it and even then will be compatible on all systems.
>> 
>>   Dmitry, please send the exact error that you got that inspired you to add this to the Gnumake package.
>> 
>>  Barry
>> 
>>> On Oct 9, 2015, at 1:24 PM, Satish Balay <pullrequests-reply at bitbucket.org> wrote:
>>> 
>>> 	
>>> Satish Balay commented on pull request #375:
>>> Pass LDFLAGS down to GNUPackage externalpackages.
>>> Nightlybuilds broke due to this change [primarily --download-mpich - esp with clang+gfortran - and other combinations]
>>> View this pull request or add a comment by replying to this email.
>>> Unsubscribe from pull request emails for this repository.		                     
>> 
>>