[petsc-dev] bug in shell.c

[Matthew Knepley]

On Sun, Mar 29, 2015 at 11:32 AM, gouarin <loic.gouarin at math.u-psud.fr>
wrote:

> Hi,
>
> I think that there is a bug in the MatMultAdd_Shell function when entries
> y and z are the same Vec. It is not possible to call
>
> VecWAXPY(z,1.0,shell->right_add_work,y);
>
> if z and y are the same Vec.
>
> I have attached a patch.
>

Good catch, but this has been fixed in master:


https://bitbucket.org/petsc/petsc/src/23524bc85f88d7c2c867e276c52fc9d9816c7ba0/src/mat/impls/shell/shell.c?at=master#cl-259

  Thanks,

    Matt


> Best,
> Loic
>
> --
> Loic Gouarin
> Laboratoire de Mathématiques
> Université Paris-Sud
> Bâtiment 425
> 91405 Orsay Cedex
> France
> Tel: (+33) 1 69 15 60 14
> Fax: (+33) 1 69 15 67 18
>
>


-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20150329/16b260fd/attachment.html>