[petsc-dev] lots o' dead code in BuildSystem

[Barry Smith]

On Oct 1, 2014, at 6:45 AM, Aron Ahmadia <aron at ahmadia.net> wrote:

> Vulture is a static code analyzer, so it's going to miss anything that's dynamically instantiated.

   Which in our case is essentially nothing :-)


> 
> On Wed, Oct 1, 2014 at 6:31 AM, Matthew Knepley <knepley at gmail.com> wrote:
> Lots of this is just unused code paths in that particular configure. However, we
> can probably eliminate the 'build' directory, BiudlSystem.sourceDatabase and PETSc.FEM
> 
>    Matt
> 
> On Tue, Sep 30, 2014 at 11:11 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> 
> ~/Src/petsc  barry/remove-sidl $ Vulture config
> config/builder.py:605: Unused variable 'comparsion'
> config/builder.py:639: Unused function 'extractTests'
> config/builder.py:663: Unused attribute 'cmd'
> config/builder.py:684: Unused attribute 'ret'
> config/builder.py:684: Unused attribute 'store'
> config/builder.py:704: Unused function 'updateNode'
> config/builder.py:1093: Unused attribute 'memAlign'
> config/builder.py:1250: Unused attribute 'operationFailed'
> config/builder.py:1290: Unused function 'compileCUDA'
> config/builder.py:1293: Unused function 'compileCxx'
> config/builder.py:1296: Unused function 'compileFortran'
> config/builder.py:1342: Unused function 'compileCParallel'
> config/builder.py:1345: Unused function 'compileCxxParallel'
> config/builder.py:1348: Unused function 'compileFortranParallel'
> config/builder.py:1374: Unused function 'expandArchive'
> config/builder.py:1677: Unused function 'checkTestOutput'
> config/builder.py:1680: Unused function 'checkTestOutputSolver'
> config/builder.py:1777: Unused function 'buildEtags'
> config/BuildSystem/args.py:69: Unused attribute '_setCommandLine'
> config/BuildSystem/build/buildGraph.py:71: Unused function 'removeSubgraph'
> config/BuildSystem/build/compile/C.py:6: Unused attribute 'usingC'
> config/BuildSystem/build/compile/Cxx.py:6: Unused attribute 'usingCxx'
> config/BuildSystem/build/compile/F90.py:6: Unused attribute 'usingF90'
> config/BuildSystem/build/fileset.py:181: Unused class 'RootedExtensionFileSet'
> config/BuildSystem/build/fileState.py:61: Unused class 'GenericTag'
> config/BuildSystem/build/fileState.py:106: Unused class 'Update'
> config/BuildSystem/build/framework.py:27: Unused attribute 'directories'
> config/BuildSystem/build/framework.py:78: Unused function 'makeSourceDBPathsAbsolute'
> config/BuildSystem/build/framework.py:87: Unused function 'makeSourceDBPathsRelative'
> config/BuildSystem/build/framework.py:103: Unused variable 'newTmp'
> config/BuildSystem/build/framework.py:177: Unused function 't_activate'
> config/BuildSystem/build/framework.py:184: Unused function 't_deactivate'
> config/BuildSystem/build/framework.py:195: Unused function 't_configure'
> config/BuildSystem/build/framework.py:259: Unused function 't_compile'
> config/BuildSystem/build/framework.py:264: Unused function 't_compilePrograms'
> config/BuildSystem/build/framework.py:271: Unused function 't_install'
> config/BuildSystem/build/framework.py:290: Unused function 't_uninstall'
> config/BuildSystem/build/framework.py:306: Unused function 't_citool'
> config/BuildSystem/build/framework.py:312: Unused function 't_push'
> config/BuildSystem/build/framework.py:321: Unused function 't_pull'
> config/BuildSystem/build/framework.py:331: Unused function 't_makeStamp'
> config/BuildSystem/build/framework.py:339: Unused function 't_default'
> config/BuildSystem/build/framework.py:343: Unused function 't_printTargets'
> config/BuildSystem/build/framework.py:357: Unused function 't_purge'
> config/BuildSystem/build/framework.py:374: Unused function 't_update'
> config/BuildSystem/build/processor.py:341: Unused class 'DirectoryArchiver'
> config/BuildSystem/build/processor.py:386: Unused class 'Archiver'
> config/BuildSystem/build/processor.py:460: Unused class 'ImportSharedLinker'
> config/BuildSystem/build/processor.py:507: Unused class 'LibraryAdder'
> config/BuildSystem/build/transform.py:41: Unused class 'Filter'
> config/BuildSystem/build/transform.py:59: Unused class 'Remover'
> config/BuildSystem/build/transform.py:80: Unused class 'Consolidator'
> config/BuildSystem/config/base.py:189: Unused function 'addArgumentSubstitution'
> config/BuildSystem/config/base.py:279: Unused function 'getExecutables'
> config/BuildSystem/config/base.py:658: Unused function 'splitIncludes'
> config/BuildSystem/config/compile/processor.py:70: Unused function 'pushRequiredFlags'
> config/BuildSystem/config/compile/processor.py:73: Unused function 'popRequiredFlags'
> config/BuildSystem/config/compilers.py:21: Unused attribute 'cRestrict'
> config/BuildSystem/config/compilers.py:22: Unused attribute 'cxxRestrict'
> config/BuildSystem/config/framework.py:366: Unused function 'updatePackageDependencies'
> config/BuildSystem/config/framework.py:465: Unused function 'addSubstitutionFile'
> config/BuildSystem/config/framework.py:938: Unused attribute '_configured'
> config/BuildSystem/config/package.py:61: Unused attribute 'double'
> config/BuildSystem/config/package.py:62: Unused attribute 'complex'
> config/BuildSystem/config/package.py:63: Unused attribute 'requires32bitint'
> config/BuildSystem/config/package.py:94: Unused attribute 'openmpi'
> config/BuildSystem/config/package.py:542: Unused variable 'foundLibrary'
> config/BuildSystem/config/package.py:543: Unused variable 'foundHeader'
> config/BuildSystem/config/packages/cuda.py:24: Unused attribute 'ThrustVersionStr'
> config/BuildSystem/config/packages/cuda.py:25: Unused attribute 'CUSPVersionStr'
> config/BuildSystem/config/packages/MPI.py:46: Unused attribute 'shared'
> config/BuildSystem/config/packages/MPI.py:48: Unused attribute 'commf2c'
> config/BuildSystem/config/packages/MPI.py:49: Unused attribute 'commc2f'
> config/BuildSystem/config/packages/MPI.py:181: Unused attribute 'haveFinalized'
> config/BuildSystem/config/packages/MPI.py:184: Unused attribute 'haveInPlace'
> config/BuildSystem/config/packages/MPI.py:188: Unused attribute 'haveTypeCreateStruct'
> config/BuildSystem/config/packages/MPI.py:193: Unused attribute 'haveCommCreateErrhandler'
> config/BuildSystem/config/packages/MPI.py:198: Unused attribute 'haveCommSetErrhandler'
> config/BuildSystem/config/packages/MPI.py:410: Unused attribute 'havef90module'
> config/BuildSystem/config/packages/mpi4py.py:14: Unused attribute 'numpy'
> config/BuildSystem/config/packages/mpi4py.py:22: Unused variable 'pp'
> config/BuildSystem/config/packages/mpi4py.py:24: Unused variable 'apple'
> config/BuildSystem/config/packages/SuperLU_MT.py:12: Unused attribute 'worksonWindows'
> config/BuildSystem/config/packages/Triangle.py:28: Unused variable 'installmakeinc'
> config/BuildSystem/config/python.py:12: Unused attribute 'isShared'
> config/BuildSystem/config/regression/frameworkTest.py:10: Unused class 'FrameworkTest'
> config/BuildSystem/config/regression/frameworkTest.py:42: Unused function 'testEmptyConfigure'
> config/BuildSystem/config/regression/frameworkTest.py:47: Unused function 'testLogName'
> config/BuildSystem/config/regression/frameworkTest.py:54: Unused function 'testFullDefaultConfigure'
> config/BuildSystem/config/regression/shellTest.py:6: Unused class 'ShellTest'
> config/BuildSystem/config/regression/shellTest.py:14: Unused function 'testTimeout'
> config/BuildSystem/config/setCompilers.py:22: Unused attribute 'usedMPICompilers'
> config/BuildSystem/config/setCompilers.py:622: Unused attribute 'compilerVersionCUDA'
> config/BuildSystem/config/setCompilers.py:997: Unused attribute 'usePIC'
> config/BuildSystem/config/setCompilers.py:1020: Unused attribute 'isPIC'
> config/BuildSystem/config/setCompilers.py:1197: Unused attribute 'staticLinker'
> config/BuildSystem/config/setCompilers.py:1287: Unused function 'addLinkerFlag'
> config/BuildSystem/config/setCompilers.py:1373: Unused attribute 'staticLibrary'
> config/BuildSystem/config/setCompilers.py:1374: Unused attribute 'sharedLibrary'
> config/BuildSystem/config/setsBackport.py:454: Unused function 'union_update'
> config/BuildSystem/config/setsBackport.py:464: Unused function 'intersection_update'
> config/BuildSystem/config/setsBackport.py:541: Unused function 'discard'
> config/BuildSystem/config/setsOrdered.py:547: Unused function 'updateDuplicate'
> config/BuildSystem/config/setsOrdered.py:633: Unused class 'SetsTest'
> config/BuildSystem/config/setsOrdered.py:634: Unused function 'testOrdering'
> config/BuildSystem/config/setsOrdered.py:640: Unused function 'testUniqueness'
> config/BuildSystem/config/setsOrdered.py:646: Unused function 'testOrder'
> config/BuildSystem/config/sourceControl.py:31: Unused attribute 'gitversion'
> config/BuildSystem/config/sourceControl.py:42: Unused attribute 'hgversion'
> config/BuildSystem/config/sourceControl.py:51: Unused attribute 'cvxversion'
> config/BuildSystem/config/sourceControl.py:60: Unused attribute 'svnversion'
> config/BuildSystem/config/types.py:128: Unused function 'checkFortranStar'
> config/BuildSystem/maker.py:33: Unused function 'getMake'
> config/BuildSystem/maker.py:232: Unused class 'BasicMake'
> config/BuildSystem/nargs.py:5: Unused function 'getInteractive'
> config/BuildSystem/nargs.py:46: Unused function 'setTemporary'
> config/BuildSystem/nargs.py:144: Unused function 'getKey'
> config/BuildSystem/nargs.py:206: Unused class 'ArgFuzzyBool'
> config/BuildSystem/nargs.py:274: Unused class 'ArgReal'
> config/BuildSystem/nargs.py:390: Unused class 'ArgExecutable'
> config/BuildSystem/RDict.py:269: Unused function 'hasType'
> config/BuildSystem/RDict.py:541: Unused function 'handle'
> config/BuildSystem/retrieval.py:123: Unused function 'ftpRetrieve'
> config/BuildSystem/retrieval.py:127: Unused function 'httpRetrieve'
> config/BuildSystem/retrieval.py:131: Unused function 'fileRetrieve'
> config/BuildSystem/retrieval.py:135: Unused function 'svnRetrieve'
> config/BuildSystem/retrieval.py:147: Unused function 'bkUpdate'
> config/BuildSystem/retrieval.py:217: Unused function 'retrieve'
> config/BuildSystem/retrieval.py:239: Unused function 'removeRoot'
> config/BuildSystem/retrieval.py:261: Unused function 'bkfileRetrieve'
> config/BuildSystem/retrieval.py:266: Unused function 'sshRetrieve'
> config/BuildSystem/retrieval.py:271: Unused function 'oldRetrieve'
> config/BuildSystem/script.py:41: Unused attribute 'shell'
> config/BuildSystem/script.py:83: Unused attribute '_setup'
> config/BuildSystem/script.py:293: Unused attribute 'outputFiles'
> config/BuildSystem/script.py:414: Unused function 'setPreprocessorObject'
> config/BuildSystem/script.py:428: Unused function 'setCompilerObject'
> config/BuildSystem/script.py:444: Unused function 'setLinkerObject'
> config/BuildSystem/script.py:476: Unused function 'setDynamicLinkerObject'
> config/BuildSystem/sourceDatabase.py:185: Unused function 'clearSource'
> config/BuildSystem/sourceDatabase.py:194: Unused function 'getDependencies'
> config/BuildSystem/sourceDatabase.py:215: Unused function 'calculateDependencies'
> config/BuildSystem/sourceDatabase.py:281: Unused class 'DependencyAnalyzer'
> config/BuildSystem/urlMappingInstalled.py:14: Unused function 'setupUrlMapping'
> config/cmakeboot.py:22: Unused function 'quoteIfNeeded'
> config/cmakegen.py:64: Unused function 'unexpected'
> config/examples/arch-bgp-ibm-opt.py:63: Unused variable 'test_options'
> config/PETSc/Configure.py:58: Unused attribute 'atomics'
> config/PETSc/Configure.py:739: Unused variable 'langs'
> config/PETSc/FEM.py:877: Unused function 'createFaceQuadrature'
> config/PETSc/FEM.py:904: Unused attribute 'list'
> config/PETSc/FEM.py:907: Unused attribute 'type'
> config/PETSc/FEM.py:909: Unused attribute 'static'
> config/PETSc/FEM.py:910: Unused attribute 'initializer'
> config/PETSc/FEM.py:923: Unused attribute 'identifier'
> config/PETSc/FEM.py:924: Unused attribute 'replacementText'
> config/PETSc/FEM.py:1098: Unused function 'getReferenceTensor'
> config/PETSc/FEM.py:1357: Unused attribute 'typedef'
> config/PETSc/FEM.py:1386: Unused function 'getQuadratureSetup'
> config/PETSc/FEM.py:1394: Unused attribute 'branch'
> config/PETSc/FEM.py:1449: Unused function 'getIntegratorPoints'
> config/PETSc/FEM.py:1510: Unused attribute 'caseLabel'
> config/PETSc/FEM.py:1569: Unused function 'getIntegratorSetup'
> config/PETSc/FEM.py:1578: Unused function 'getSectionSetup'
> config/PETSc/FEM.py:1669: Unused function 'getElementIntegrals'
> config/PETSc/FEM.py:1696: Unused attribute 'parameters'
> config/PETSc/FEM.py:1758: Unused attribute 'comments'
> config/PETSc/FEM.py:1814: Unused attribute 'purpose'
> config/PETSc/FEM.py:1904: Unused function 'runTensorProduct'
> config/PETSc/utilities/arch.py:54: Unused attribute 'archBase'
> config/PETSc/utilities/cacheDetails.py:29: Unused attribute 'updated'
> config/PETSc/utilities/CHUD.py:39: Unused attribute 'haveCHUD'
> config/PETSc/utilities/libraryOptions.py:33: Unused attribute 'scalarTypes'
> config/PETSc/utilities/missing.py:86: Unused function 'configureMissingErrnos'
> config/PETSc/utilities/Regression.py:27: Unused attribute ‘elemental'
> 
> 
> 
> 
> -- 
> What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.
> -- Norbert Wiener
>