[petsc-dev] get rid of petscsys.hh?

[Barry Smith]

How about just embedding the information directly into the petscsys.h file and putting a comment explaining its purpose


> On Jan 2, 2014, at 10:10 AM, Matthew Knepley <knepley at gmail.com> wrote:
> 
> 
>> On Wed, Jan 1, 2014 at 2:10 PM, Barry Smith <barryfsmith at me.com> wrote:
>> 
>>   Matt,
>> 
>>    You removed petscsys.hh but also need to remove its dependencies
> 
> I don't think we can remove this. I fixed the include.
> 
>    Matt
>  
>>         CXX arch-pylith-gcc-opt/obj/src/sys/error/err.o
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc/petsc-pylith/binaries/src/sys/error/err.c: In function 'void PetscCxxErrorThrow()':
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc/petsc-pylith/binaries/src/sys/error/err.c:304:5: error: 'ostringstream' is not a member of 'std'
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc
>> /petsc-pylith/binaries/src/sys/error/err.c:304:25: error: 'msg' was not declared in this scope
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc/petsc-pylith/binaries/src/sys/error/err.c:305:12: error: 'ostringstream' is not a member of 'std'
>> 
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc/petsc-pylith/binaries/src/sys/error/err.c:305:31: error: expected primary-expression before ')' token
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc/petsc-pylith/binaries/src/sys/error/err.c:305:33: error: expected ';' before 'eh'
>> /Users/buildbot/slave/build/pylith_darwin_10.6_binbot/PETSc/petsc-pylith/binaries/src/sys/error/err.c:309:9: error: 'PETSc' has not been declared
>> make[2]: *** [arch-pylith-gcc-opt/obj/src/sys/error/err.o] Error 1
>> 
>> On Dec 26, 2013, at 2:59 PM, Matthew Knepley <knepley at gmail.com> wrote:
>> 
>> > On Thu, Dec 26, 2013 at 2:41 PM, Barry Smith <barryfsmith at me.com> wrote:
>> >
>> >
>> >     Can we get rid of petscsys.hh which still? seems to be lurking in master?
>> >
>> > I will get rid of it.
>> >
>> >   Matt
>> >
>> >    Thanks
>> >
>> >    Barry
>> >
>> > /* Special support for C++ */
>> > #if defined(PETSC_CLANGUAGE_CXX) && defined(__cplusplus)
>> > #include <petscsys.hh>
>> > #endif
>> >
>> >
>> >
>> >
>> >
>> >
>> > --
>> > What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.
>> > -- Norbert Wiener
> 
> 
> 
> -- 
> What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.
> -- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20140102/fb6db4f1/attachment.html>