[petsc-dev] TaoTerminationReason -> TaoConvergedReason

[Barry Smith]

On Feb 18, 2014, at 10:12 AM, Jason Sarich <jason.sarich at gmail.com> wrote:

> Yes, I'll rename them under Tao and make them PETSC_INTERNAL.

   Thanks, move the declarations to taoimpl.h also and do it in the barry/tao-fixes-for-petsc4py branch. Just put Tao in front of them.

   We should eventually clean this stuff up and merge into VecGetSubVector() and MatGetSubMatrix() and unify usage in all of PETSc but will require some thought and care so I have added an issue https://bitbucket.org/petsc/petsc/issue/58/cleanup-taovecmatgetsubvec-and-unify-into instead of doing it rapidly and poorly now.

   It is generally useful stuff and after cleanup should be used by SNESVI also.

   Barry


> 
> I don't think using the VI routines is a good idea at the moment, those are attached to SNES objects.
> 
> Jason
> 
> 
> On Tue, Feb 18, 2014 at 10:06 AM, Jed Brown <jed at jedbrown.org> wrote:
> Jason Sarich <jason.sarich at gmail.com> writes:
> 
> > These functions are for eliminating the variables corresponding to active
> > sets when performing matrix, vector operations. I don't think they were
> > meant to be in the public interface, only for utilities in active set
> > algorithms.
> 
> Okay, can you either make them PETSC_INTERNAL and namespace them or
> replace them?
>