[petsc-dev] bitbucket giving wrong information

Jed Brown jed at jedbrown.org
Thu Dec 4 21:25:44 CST 2014


Barry Smith <bsmith at mcs.anl.gov> writes:
>     It seems to me the simplest way is simply to include the PR number
>     into the new local branch name that person made. I don't see why
>     we need any of the complicated goobly guck below if we just follow
>     my proposal above. Nor do I see any harm in my proposal. If you
>     want to provide also a description of the pull request
>     functionality we could have
>
>      myuserid/pullrequest-number-mychosendescription

Fine, do you have a preference between these?

  pr123/username/description
  username/pr123-description

Spelling out "pullrequest" uses a lot of line space

>   "Annotating the PR # into the merge commit" as an additional convention is fine with me also but is orthogonal to the finding above."

Sure, but valuable because the reference shows up as a PR comment so
it's easier to tell when a given PR is in 'next'.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20141204/47b3632d/attachment.sig>


More information about the petsc-dev mailing list