[petsc-dev] Fine-grained style checker script ready

Karl Rupp rupp at mcs.anl.gov
Tue Mar 5 16:50:43 CST 2013


Hey,


> How about
>
>     make std
>
> :).

Not bad, but doesn't make it clear what is going on. What about
   make barry happy
which is easy to remember and makes it rather clear that it's about 
style :-)

Best regards,
Karli



> What about making it a pre-commit hook?
>
>      Matt
>
>       $> make stylediff
>     ? Other suggestions?
>
>     Best regards,
>     Karli
>
>
>
>     On 03/05/2013 03:45 PM, Karl Rupp wrote:
>
>         Dear PETScians,
>
>         it is now possible to obtain a style violation summary on a per-file
>         basis. The script is
>             ${PETSC_DIR}/src/contrib/__style/stylecheck.sh
>         and runs all stable^1 checks on the provided subfolder(s) or
>         files(s).
>
>         Examples:
>
>         - Report all violations in src/ts:
>         $:petsc-dev> src/contrib/style/stylecheck.__sh src/ts
>
>         - Report all violations in power_grid/ex8.c:
>         $:petsc-dev> src/contrib/style/stylecheck.__sh \
>             src/ts/examples/tutorials/__power_grid/ex8.c
>
>         I'm currently trying to fuse the script with `hg status` so that
>         one can
>         conveniently run it on all new or modified files. Please let me
>         know of
>         any issues you encounter.
>
>         Best regards,
>         Karli
>
>         ^1 A stable check is a check that causes less than ~100
>         complaints over
>         all of src/, see http://krupp.iue.tuwien.ac.at/__petsc-style/
>         <http://krupp.iue.tuwien.ac.at/petsc-style/>
>
>
>
>
>
> --
> What most experimenters take for granted before they begin their
> experiments is infinitely more interesting than any results to which
> their experiments lead.
> -- Norbert Wiener




More information about the petsc-dev mailing list