[petsc-dev] nightly builds

[Peter Brune]

I thought about doing this as a standard thing, and came to the conclusion
that it amounted to subjecting our users who use the PETSc compiler
configuration to the procrustean bed.  It's mostly useful to those of us
pushing to master and next.

- Peter


On Fri, Jul 5, 2013 at 5:38 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> Satish Balay <balay at mcs.anl.gov> writes:
>
> > On Fri, 5 Jul 2013, Peter Brune wrote:
> >
> >> -Wdeclaration-after-statement -Werror=declaration-after-statement
> >>
> >> Is super useful and is now added to all my arches. :)
> >
> > perhaps we should change configure defaults to use this?
> >
> > diff --git a/config/BuildSystem/config/compilerOptions.py
> b/config/BuildSystem/config/compilerOptions.py
> > index dadc5fb..e372bb0 100644
> > --- a/config/BuildSystem/config/compilerOptions.py
> > +++ b/config/BuildSystem/config/compilerOptions.py
> > @@ -18,7 +18,7 @@ class CompilerOptions(config.base.Configure):
> >      # GNU gcc
> >      if config.setCompilers.Configure.isGNU(compiler) or
> config.setCompilers.Configure.isClang(compiler):
> >        if bopt == '':
> > -        flags.extend(['-Wall', '-Wwrite-strings',
> '-Wno-strict-aliasing','-Wno-unknown-pragmas'])
> > +        flags.extend(['-Wall', '-Wwrite-strings',
> '-Wno-strict-aliasing','-Wno-unknown-pragmas','-Wdeclaration-after-statement','-Werror=declaration-after-statement'])
>
> I would probably skip the -Werror=... part and just recommend that
> developers use CFLAGS=-Werror (treat all warnings as errors).
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130705/5dbb90ef/attachment.html>