[petsc-dev] Compliant C89

[Barry Smith]

On Jan 14, 2013, at 1:32 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> On Mon, Jan 14, 2013 at 1:29 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> > PetscErrorCode PetscBLASIntCast(PetscInt,PetscBLASInt*);
> 
>    Ugly…. man, but I guess the right thing to do.
> 
> We can put it in a macro, but still use argument passing, i.e.,
> 
> #define PetscBLASIntCast(pint,blasint) do { ... } while (0)
> 
> which will now not be allowed in declarations, but still be syntactically lighter.

  I thought we agreed that we were moving away from using Macros whenever possible, so since the right thing to do PEYSc style is PetscErrorCode PetscBLASIntCast(PetscInt,PetscBLASInt*); then we should just do it with inline functions the right way.

   Barry