[petsc-dev] Use of PETSC_DEFAULT in Chaco interface

[Jose E. Roman]

El 02/02/2013, a las 22:06, Jed Brown escribió:

> /home/jed/petsc/src/mat/partition/impls/chaco/chaco.c:484:13: warning: comparison of constant -2 with expression of type 'MPChacoEigenType' is always false [-Wtautological-c
> onstant-out-of-range-compare]
>   if (method==PETSC_DEFAULT) chaco->eigen_method = MP_CHACO_LANCZOS;
>       ~~~~~~^ ~~~~~~~~~~~~~
> 
> Meanwhile, we have
> 
> typedef enum { MP_CHACO_LANCZOS=0,MP_CHACO_RQI=1 } MPChacoEigenType;
> 
> Either we add a typed MP_CHACO_DEFAULT to the enum or we get rid of the concept of PETSC_DEFAULT in that context. Which is it?

This is probably my fault. I think PETSC_DEFAULT is not necessary here. Just initialize chaco->eigen_method to 0 (Chaco's default). Can you fix it?

Jose