[petsc-dev] [tao-comments #191525] PetscNewLog signature change

[Todd Munson]

The idea is to distribute TAO with PETSc and treat it like any other set of PETSc solves.
All the TaoLog (or TaoNewLog) macros should go away in my opinion and be replace with
the correct PETSc equivalents.

Jason?  

Todd.


On Dec 12, 2013, at 2:38 PM, Geoffrey Irving <irving at naml.us> wrote:

> This (nice) change is preventing the TAO development branch from
> compiling against PETSc master.  What's the best way to fix it?  This
> is mainly a question for TAO folk, but I'm cc'ing petsc-dev in case
> Jed has opinions on the best way to maintain external libraries.
> 
> I'm happy to implement whatever change is suggested, either by running
> Jed's script or making a variant that replaces PetscNewLog with a
> TaoNewLog compatibility macro.
> 
> Thanks,
> Geoffrey
> 
> commit b00a91154f763f12aa55f3d53a3f2776f15f49e3
> Author: Jed Brown <jedbrown at mcs.anl.gov>
> Date:   Tue Dec 3 12:54:21 2013 -0600
> 
>    Sys: drop explicit type arguments from PetscNew() and PetscNewLog()
> 
>    git grep -l 'PetscNew\(Log\)\?(' -- $1 | xargs perl -pi -e '
>    s at PetscNew\([^,;()]+ *, *@PetscNew(@;
>    s at PetscNewLog\(([^,;()]+) *,[^,;()]+, *@PetscNewLog($1,@'
>