[petsc-dev] Enabling single precision for MUMPS and SUPERLU

[Barry Smith]

On Sep 21, 2012, at 9:59 AM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> On Fri, Sep 21, 2012 at 9:55 AM, Barry Smith <bsmith at mcs.anl.gov> wrote:
>             I understand why you are doing this (since xmumps_c appears in multiple places in the code and you don't want the ugly #ifdef at each of those places) but essentially you are doing what the mumps people should have done, providing a polymorphic interface to their solver. By doing this you are making the PETSc--mumps interface less transparent and introducing the complexity of additional macros. I think it would be better to use the old style we had (where the #ifdef appear each time as needed in the code).
> 
> I have mixed feelings about his. We use the top-level macros in the UMFPACK, CHOLMOD,

    Who the hell did that? :-)


> and even BLAS/Lapack.

   Ok, you convinced me. I'm fine with the macros. Maybe better names? Are the umfpack names ok, they don't have PETSc in them.

   Barry