[petsc-dev] use of deprecated DMSetFunction() approach

Barry Smith bsmith at mcs.anl.gov
Mon Nov 26 12:59:24 CST 2012

On Nov 25, 2012, at 1:40 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> On Sun, Nov 25, 2012 at 7:58 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
>    Totally awesome!  And can I ask why someone who made the obvious effort to write all this cool better new code didn't spend ten minutes to change the use of DMDASetFunctionLocal() in the examples to the new format  and strip out the old code that did the outdated wrong way?   Support for backward capability is the work of the devil, just don't do it!
> We used it in SNES ex5, SNES ex48, and TS ex26. Are there any other examples that matter? ;-D
> You're right, this was bad behavior. I remember updating lots of examples, but it looks like most of what I updated was not using the local functions.
>    Ok I will try to update the examples shortly and strip out that old code that should have been removed in March.

   Ok, DMDASetLocalFunction/Jacobian() and its usage has all been stripped out of PETSc dev and updated to use DMDASNESSetXXXXXX(). 

   Next the DMSetFunctionLocal() stuff has to be reworked to not use DM as the storage space, will be starting on that now.



More information about the petsc-dev mailing list