[petsc-dev] petsc/petsc-dev someone changed DM to __PETSc_dm for the name of a DM attached to a Mat object but didn't change its use everywhere (commit 6e9d4e780b4d4f1b06b023485bbcf786a79fb6fe)

[Barry Smith]

On Nov 20, 2012, at 2:30 PM, Matt Knepley <notifications-noreply at bitbucket.org> wrote:

> New comment on changeset:
> 
> https://bitbucket.org/petsc/petsc-dev/changeset/6e9d4e780b4d4f1b06b023485bbcf786a79fb6fe#comment-70978
> 
> Matt Knepley (knepley) said:
> 
> What the heck are those calls doing in examples? The user should NEVER NEVER NEVER be doing that. There are accessors for that.

   There is an accessor for doing

  ierr = PetscObjectCompose((PetscObject)J,"__PETSc_dm",(PetscObject)PETSC_NULL);CHKERRQ(ierr);

?

   BTW: if you are going to write accessors like MatSetDM() then why go through the PetscObjectCompose() nonsense? Why not just stick the dm into the mat data structure as a void * in your accessor?

   

   
> 
> --
> This is an comment notification from bitbucket.org.
> You are receiving this because you are participating
> in a comment thread.