[petsc-dev] What needs to be done before a release?

[Jed Brown]

On Wed, May 30, 2012 at 12:40 AM, Satish Balay <balay at mcs.anl.gov> wrote:

> On Tue, 29 May 2012, Barry Smith wrote:
>
> >
> >    I have changed PetscBagRegisterEnum() to now properly copy the list
> of enum strings values
> >
>
> /home/balay/spetsc/src/sys/bag/bag.c: In function ‘PetscBagRegisterEnum’:
> /home/balay/spetsc/src/sys/bag/bag.c:79:3: warning: passing argument 2 of
> ‘PetscStrArrayallocpy’ from incompatible pointer type [enabled by default]
> /home/balay/spetsc/include/petscsys.h:1156:29: note: expected ‘char ***’
> but argument is of type ‘const char ***’
> /home/balay/spetsc/src/sys/bag/bag.c: In function ‘PetscBagDestroy’:
> /home/balay/spetsc/src/sys/bag/bag.c:473:7: warning: passing argument 1 of
> ‘PetscStrArrayDestroy’ from incompatible pointer type [enabled by default]
> /home/balay/spetsc/include/petscsys.h:1157:29: note: expected ‘char **’
> but argument is of type ‘const char **’
>
> if anyone has a better fix - do correct the following.
> http://petsc.cs.iit.edu/petsc/petsc-dev/rev/c62350f780f9


I prefer to be honest about const.

http://petsc.cs.iit.edu/petsc/petsc-dev/rev/44a418def4d0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120530/2213510b/attachment.html>