[petsc-dev] threadcomm memory leak

[Satish Balay]

Thats was almost 15 years ago :) from the time we used RCS - and
didn't maintain commit messages.

I think its probably more because mpiuni doesn't support more than 1
communicator and attributes are stashed in a global structure [not per
communicator].

Perhaps mpiuni needs fixing..

Satish


On Mon, 16 Jul 2012, Jed Brown wrote:

> Satish, what was the rationale behind this commit? I can't think of an
> excuse for making them be literally the same.
> 
> On Mon, Jul 16, 2012 at 11:11 AM, Satish Balay <balay at mcs.anl.gov> wrote:
> 
> > Actually for np=1 MPI_COMM_SELF==MPI_COMM_WORLD.
> >
> > mpi.h was changed to reflect this  - but mpif.h was not.
> >
> > Satish
> >
> > ----------
> > balay at petsc:~/Petsc-historic/src/sys/src/mpiuni $ rcsdiff -r1.52 -r1.53
> > mpi.h
> > ===================================================================
> > RCS file: RCS/mpi.h,v
> > retrieving revision 1.52
> > retrieving revision 1.53
> > diff -r1.52 -r1.53
> > 1c1
> > < /* $Id: mpi.h,v 1.52 1997/07/28 21:41:02 balay Exp $ */
> > ---
> > > /* $Id: mpi.h,v 1.53 1997/08/21 01:06:19 balay Exp $ */
> > 22c22
> > < #define MPI_COMM_SELF        2
> > ---
> > > #define MPI_COMM_SELF        MPI_COMM_WORLD
> > 427c427
> > <                       (MPIUNI_TMP = (void *) (comm), \
> > ---
> > >                       (*(newcomm) =  (comm), \
> > 429d428
> > <                       MPIUNI_TMP = (void *) (newcomm), \
> >
>