[petsc-dev] threadcomm memory leak

[Satish Balay]

On Mon, 16 Jul 2012, Blaise Bourdin wrote:

> 
> On Jul 16, 2012, at 10:11 AM, Jed Brown wrote:
> 
> > On Mon, Jul 16, 2012 at 10:09 AM, Shri <abhyshr at mcs.anl.gov> wrote:
> > Yes, i think so too. If no one objects then i can do that. 
> > Btw, MPI_COMM_SELF and MPI_COMM_WORLD are same in mpiuni/mpi.h
> > #define MPI_COMM_WORLD       1
> > #define MPI_COMM_SELF        MPI_COMM_WORLD
> > 
> >  while the fortran version declares these communicators as different. mpiuni/mpif.h
> >  integer MPI_COMM_WORLD
> >        parameter (MPI_COMM_WORLD = 1)
> >        integer MPI_COMM_SELF
> >        parameter (MPI_COMM_SELF = 2)
> > 
> > WAT? The Fortran version did something right?
> 
> That's because it is tested by people who do stuff with it ;)


Actually for np=1 MPI_COMM_SELF==MPI_COMM_WORLD.

mpi.h was changed to reflect this  - but mpif.h was not.

Satish

----------
balay at petsc:~/Petsc-historic/src/sys/src/mpiuni $ rcsdiff -r1.52 -r1.53 mpi.h
===================================================================
RCS file: RCS/mpi.h,v
retrieving revision 1.52
retrieving revision 1.53
diff -r1.52 -r1.53
1c1
< /* $Id: mpi.h,v 1.52 1997/07/28 21:41:02 balay Exp $ */
---
> /* $Id: mpi.h,v 1.53 1997/08/21 01:06:19 balay Exp $ */
22c22
< #define MPI_COMM_SELF        2
---
> #define MPI_COMM_SELF        MPI_COMM_WORLD
427c427
<                       (MPIUNI_TMP = (void *) (comm), \
---
>                       (*(newcomm) =  (comm), \
429d428
<                       MPIUNI_TMP = (void *) (newcomm), \
balay at petsc:~/Petsc-historic/src/sys/src/mpiuni $