[petsc-dev] BuildSystem optional requirements

[Matthew Knepley]

On Sun, Jan 1, 2012 at 5:37 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:

> This code is so fragile. Isn't there a way to say "if the user requested
> ParMetis in *any* way" instead of enumerating the list of ways that it
> could be asked for. Should we also check whether the user asked for
> ParMetis using --with-parmetis-{include,lib}? I hate the idea of checking
> argDB directly like this.
>
>       if self.framework.argDB.get('download-parmetis') or
> self.framework.argDB.get('with-parmetis'):
>         self.parmetis   = framework.require('PETSc.packages.parmetis',self)
>         self.deps.append(self.parmetis)
>

This makes zero sense on its face. Why is the dependency conditional? It
should be unconditional
and then we check whether it was found. Change it!

   Matt

-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120101/c3add215/attachment.html>