[petsc-dev] Please stop checking in debugging code

[Jed Brown]

This commit says "rm unused variables" but its primary purpose appears to
be to add non-compliant debugging code.

https://bitbucket.org/petsc/petsc-dev/commits/01c3be9a4ea1

I still don't understand why we aren't using PETSc events to profile this,
but can we all please strive to check in only compliant code? You can
always make a personal fork on bitbucket, commit all the debugging
fragments you want, then clean up your patches with histedit, and push to
petsc/petsc-dev.


/home/jed/petsc/src/mat/impls/aij/seq/matmatmult.c:37:24: warning: format
specifies type 'int' but the argument has type 'PetscInt' (aka 'long long')
[-Wformat]
      printf("    Mat %d %d, 2MultSymbolic_SeqAIJ_Scalable time:
%g\n",A->rmap->N,A->cmap->N,t1-t0);
                      ~^
~~~~~~~~~~
                      %lld
/home/jed/petsc/src/mat/impls/aij/seq/matmatmult.c:37:27: warning: format
specifies type 'int' but the argument has type 'PetscInt' (aka 'long long')
[-Wformat]
      printf("    Mat %d %d, 2MultSymbolic_SeqAIJ_Scalable time:
%g\n",A->rmap->N,A->cmap->N,t1-t0);
                         ~^
      ~~~~~~~~~~
                         %lld
/home/jed/petsc/src/mat/impls/aij/seq/matmatmult.c:46:24: warning: format
specifies type 'int' but the argument has type 'PetscInt' (aka 'long long')
[-Wformat]
      printf("    Mat %d %d, 2MultSymbolic_SeqAIJ time:
%g\n",A->rmap->N,A->cmap->N,t1-t0);
                      ~^                                      ~~~~~~~~~~
                      %lld
/home/jed/petsc/src/mat/impls/aij/seq/matmatmult.c:46:27: warning: format
specifies type 'int' but the argument has type 'PetscInt' (aka 'long long')
[-Wformat]
      printf("    Mat %d %d, 2MultSymbolic_SeqAIJ time:
%g\n",A->rmap->N,A->cmap->N,t1-t0);
                         ~^
 ~~~~~~~~~~
                         %lld
4 warnings generated.
[ 11%] Building CXX object
CMakeFiles/petsc.dir/src/mat/impls/aij/mpi/mpiptap.c.o
clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior
is deprecated
/home/jed/petsc/src/mat/impls/aij/seq/matmatmatmult.c:61:20: warning:
format specifies type 'int' but the argument has type 'PetscInt' (aka 'long
long') [-Wformat]
    printf("  Mat %d %d, 3MultSymbolic_SeqAIJ_Scalable time: %g + %g =
%g\n",A->rmap->N,A->cmap->N,t1-t0,t2-t1,t2-t0);
                  ~^
  ~~~~~~~~~~
                  %lld
/home/jed/petsc/src/mat/impls/aij/seq/matmatmatmult.c:61:23: warning:
format specifies type 'int' but the argument has type 'PetscInt' (aka 'long
long') [-Wformat]
    printf("  Mat %d %d, 3MultSymbolic_SeqAIJ_Scalable time: %g + %g =
%g\n",A->rmap->N,A->cmap->N,t1-t0,t2-t1,t2-t0);
                     ~^
            ~~~~~~~~~~
                     %lld
/home/jed/petsc/src/mat/impls/aij/seq/matmatmatmult.c:68:20: warning:
format specifies type 'int' but the argument has type 'PetscInt' (aka 'long
long') [-Wformat]
    printf("  Mat %d %d, 3MultSymbolic_SeqAIJ time: %g + %g =
%g\n",A->rmap->N,A->cmap->N,t1-t0,t2-t1,t2-t0);
                  ~^
 ~~~~~~~~~~
                  %lld
/home/jed/petsc/src/mat/impls/aij/seq/matmatmatmult.c:68:23: warning:
format specifies type 'int' but the argument has type 'PetscInt' (aka 'long
long') [-Wformat]
    printf("  Mat %d %d, 3MultSymbolic_SeqAIJ time: %g + %g =
%g\n",A->rmap->N,A->cmap->N,t1-t0,t2-t1,t2-t0);
                     ~^
   ~~~~~~~~~~
                     %lld
4 warnings generated.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20121208/14ad809e/attachment.html>