[petsc-dev] BuildSystem help

[Barry Smith]

On Apr 20, 2011, at 1:43 PM, Matthew Knepley wrote:

> On Wed, Apr 20, 2011 at 1:24 PM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> 
>   Matt,
> 
>     I wanted to add to valgrind.py a test that made sure valgrind.h was compilable. So I added a simple test
> 
> self.checkCompile('#include <valgrind/valgrind.h>','RUNNING_ON_VALGRIND;\n')
> 
> the problem is I do not know where you stash the directory where the include file is put therefor the test fails because it does not know where to look for valgrind/valgrind.h
> 
> 
> Please pull and fix this now, since configure in petsc-dev is currently broken.
> 
> Pushed. Is this what you want?

   Yes, I think it worked correctly. Note this would prevent the bad problem reported by a previous petsc-maint today about valgrind.

   BTW: When a test fails BuildSystem prints the test but when it succeeds it doesn't print the test it did. How about having self.checkCompile('#include <valgrind/valgrind.h>','RUNNING_ON_VALGRIND;\n') for example 
print the code it is testing when it succeeds also. Makes understanding what configure does easier


   Barry

> 
>    Matt
>  
>   Thanks
> 
>   Barry
> 
> 
> 
> 
> -- 
> What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.
> -- Norbert Wiener