[petsc-dev] changed ISCreateGeneral/NC/WithArray()

[Jed Brown]

Here at least PETSC_COPY_MODE doesn't really make sense as anything other
than an immediate in which case the user is getting no extra flexibility
thought the condensed API. Also, separate functions can actually be
const-correct. As I see it, the only downside of separate functions
(wrapping a common backend) is having separate man pages.

Jed

On Oct 4, 2010 1:00 AM, "Lisandro Dalcin" <dalcinl at gmail.com> wrote:

On 3 October 2010 19:51, Barry Smith <bsmith at mcs.anl.gov> wrote:
>
>   Well it is always "with array...
I'm just thinking on user convenience...


>
>   Regarding having two routines: I found having three almost identical
routines unneededly comp...
I definitely agree.


>
> You still want to have two routines, one is just a subset of the
functionality of the second. T...
If we were using C++, don't you think we could overload
ISCreateGeneral? But we are in C, and I see that
ISCreateGeneralWithArray() as a developer-level call, while
ISCreateGeneral() looks more like an user-level-call.

I'm proposing making ISCreateGeneral() a wrapper for
ISCreateGeneralWithArray(). I do not think that the redundancy is too
much of a trouble in such cases.


>   I do appreciate your suggestions, please keep on having them even if
they don't always convince...
Well, I'm still trying to convince you :-)


>
>   Barry
>
> On Oct 3, 2010, at 5:45 PM, Lisandro Dalcin wrote:
>
>> On 3 October 2010 14:57, Ba...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20101004/bd597c37/attachment.html>